Skip to content

backport: bitcoin#18417, #18521, #18529, #18176, #18423, #17926, #18353, #18407, #18455, #18565, #18867 (fuzzing harness backports: part 2)#4829

Merged
PastaPastaPasta merged 11 commits intodashpay:developfrom
kwvg:fuzz2
Jul 12, 2022
Merged

Conversation

@kwvg
Copy link
Collaborator

@kwvg kwvg commented May 7, 2022 •
edited
Loading

@github-actions
Copy link

github-actions bot commented May 19, 2022

This pull request has conflicts, please rebase.

@UdjinM6 UdjinM6 mentioned this pull request Jun 3, 2022
Merged
@kwvg kwvg mentioned this pull request Jun 12, 2022
Merged
@kwvg kwvg changed the title merge bitcoin#17685...#19286: fuzzing harness backports (part 2) backport: bitcoin#18417, #18521, #18529, #18176, #18423, #17926, #18353, #18407, #18455, #18565, #18867, #19247, #19222, #18363, #18190, #18393, partial #18047, #18314, #19143 (fuzzing harness backports: part 2) Jun 14, 2022
@kwvg kwvg requested review from PastaPastaPasta and UdjinM6 June 14, 2022 06:45
@kwvg kwvg marked this pull request as ready for review June 14, 2022 06:45
@kwvg kwvg mentioned this pull request Jun 14, 2022
Merged
@kwvg kwvg changed the title backport: bitcoin#18417, #18521, #18529, #18176, #18423, #17926, #18353, #18407, #18455, #18565, #18867, #19247, #19222, #18363, #18190, #18393, partial #18047, #18314, #19143 (fuzzing harness backports: part 2) backport: bitcoin#18417, #18521, #18529, #18176, #18423, #17926, #18353, #18407, #18455, #18565, #18867 (fuzzing harness backports: part 2) Jun 14, 2022
@kwvg kwvg marked this pull request as draft June 14, 2022 18:17
@github-actions
Copy link

github-actions bot commented Jun 18, 2022

This pull request has conflicts, please rebase.

@kwvg kwvg force-pushed the fuzz2 branch 2 times, most recently from 78993ae to 1a7c759 Compare June 18, 2022 17:48
@github-actions
Copy link

github-actions bot commented Jun 22, 2022

This pull request has conflicts, please rebase.

@Munkybooty Munkybooty mentioned this pull request Jun 28, 2022
Merged
@kwvg kwvg force-pushed the fuzz2 branch 2 times, most recently from 1091bc3 to 1e11b9e Compare July 4, 2022 06:38
@kwvg kwvg marked this pull request as ready for review July 5, 2022 10:10
UdjinM6
UdjinM6 requested changes Jul 5, 2022
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI complains:

In file included from test/fuzz/cuckoocache.cpp:5:
./cuckoocache.h:431:13: error: no matching function for call to 'swap'
            std::swap(table[last_loc], e);
            ^~~~~~~~~
test/fuzz/cuckoocache.cpp:43:26: note: in instantiation of member function 'CuckooCache::cache<bool, (anonymous namespace)::RandomHasher>::insert' requested here
            cuckoo_cache.insert(fuzzed_data_provider.ConsumeBool());

@kwvg kwvg force-pushed the fuzz2 branch 2 times, most recently from dca5f26 to 1eed917 Compare July 6, 2022 16:35
@kwvg kwvg requested a review from UdjinM6 July 6, 2022 19:33
@UdjinM6 UdjinM6 added this to the 18.1 milestone Jul 8, 2022
UdjinM6
UdjinM6 approved these changes Jul 8, 2022
View reviewed changes
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (compiles locally with --enable-fuzz), utACK

@PastaPastaPasta
Copy link
Member

PastaPastaPasta commented Jul 12, 2022 •
edited
Loading 

  CXX      test/fuzz/asmap_direct-asmap_direct.o
test/fuzz/asmap_direct.cpp:30:25: error: variable 'sep_pos' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
    if (buffer.size() - sep_pos - 1 > 128) return; // At most 128 bits in IP address
                        ^~~~~~~
test/fuzz/asmap_direct.cpp:17:19: note: initialize the variable 'sep_pos' to silence this warning
    size_t sep_pos;
                  ^
                   = 0
1 error generated.
make[2]: *** [test/fuzz/asmap_direct-asmap_direct.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/Library/Developer/CommandLineTools/usr/bin/clang -mmacosx-version-min=10.15 -isysroot/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -O2  -std=c89 -pedantic -Wno-long-long -Wnested-externs -Wshadow -Wstrict-prototypes -Wundef -Wno-overlength-strings -Wall -Wno-unused-function -Wextra -Wcast-align -Wconditional-uninitialized -fvisibility=hidden  -pipe -O2  -L/Users/pasta/workspace/dash/depends/aarch64-apple-darwin21.5.0/lib  gen_context.o -o gen_context
./gen_context
test/fuzz/addrdb.cpp:21:21: error: unused variable 'ban_entry' [-Werror,-Wunused-variable]
    const CBanEntry ban_entry = [&] {
                    ^
1 error generated.
make[2]: *** [test/fuzz/addrdb-addrdb.o] Error 1
  CC       src/libsecp256k1_la-secp256k1.lo
  CCLD     libsecp256k1.la
make[1]: *** [check-recursive] Error 1
make: *** [check-recursive] Error 1

PastaPastaPasta
PastaPastaPasta approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK for merging via merge commit

Note: there are build errors when using --enable-fuzz and --enable-werror. I have asked @kittywhiskers to create an issue to track this.

@kwvg kwvg mentioned this pull request Jul 12, 2022
Closed
@PastaPastaPasta PastaPastaPasta merged commit eefdae1 into dashpay:develop Jul 12, 2022
@kwvg kwvg mentioned this pull request Aug 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UdjinM6 UdjinM6 UdjinM6 approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.1

Development

Successfully merging this pull request may close these issues.

3 participants

@kwvg @PastaPastaPasta @UdjinM6

Comments